Skip to content

Commit

Permalink
grammar
Browse files Browse the repository at this point in the history
  • Loading branch information
graebm committed Oct 7, 2023
1 parent ff27312 commit 92702fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions source/s3_meta_request.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,8 @@ static void s_s3_request_on_finish(
/*************** GIL RELEASE ***************/
}

/* Invoked when the python object get cleaned up.
* DO NOT destroy the binding or anything inside it yet.
/* Invoked when S3Request._binding gets cleaned up.
* DO NOT destroy the C binding struct or anything inside it yet.
* The user might have let S3Request get GC'd,
* but the s3_meta_request_binding* must outlive the native aws_s3_meta_request* */
static void s_s3_meta_request_capsule_destructor(PyObject *capsule) {
Expand Down
2 changes: 1 addition & 1 deletion test/test_s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def test_get_object_file_object(self):

# Regression test: Let S3Request get GC'd early.
# The download should continue without problems.
# We once had a bug where the file would get close too early:
# We once had a bug where the file would get closed too early:
# https://github.com/awslabs/aws-crt-python/pull/506
del s3_request

Expand Down

0 comments on commit 92702fe

Please sign in to comment.