Fix issue with mvn-install target in build.xml. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introducing Dynamic and Static client modes for the memcached client. Dynamic allows the client to automatically pick up the node list using the ElastiCache configuration endpoint throughout the lifetime of the client object. Static mode is the existing behavior, where the client is initialized only once using the configuration provided by the user. * Support for a new configuration command used in ElastiCache Nodes. This command supports the config get, set and delete commands in ASCII and binary mode. * Periodic poller to check for node list changes in the ElastiCache cluster and dynamically update client connections according to the configuration. This operates only in Dynamic mode. * In dynamic mode, if IP addresses are specified in the configuration, then the connection is established using the IP address directly. For more information, please see http://docs.amazonwebservices.com/AmazonElastiCache/latest/UserGuide/AutoDiscovery.html
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with the mvn-install target in build.xml. In the current code in master branch, when I run "ant mvn-install", I see the following error: "build.xml:499: java.lang.ClassCastException: org.apache.tools.ant.Project cannot be cast to org.apache.maven.artifact.ant.Pom"
This is because the pom id is set to be "spymemcached" on line 498, whereas the code below looks for ${name} which is "AmazonElastiCacheClusterClient". Similar issue is on line 506.
This patch is tested in both mac and linux.