Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonDeserializer does not allow enabling/disabling a feature for Jackson Object Mapper #325

Open
clkelly-r7 opened this issue Jan 30, 2024 · 4 comments

Comments

@clkelly-r7
Copy link

clkelly-r7 commented Jan 30, 2024

JsonDeserializer does not allow setting DeserializationFeatures with a state (to enable/disable a feature), it only sets the default state unless I'm missing something on how to pass the DeserializationFeature in.
Was looking through the code for the JsonDeserializer class and the this.objectMapper::enable only seems to allow enabling the DeserializationFeature with the default state. Whereas I need to be able to set boolean flag for a DeserializationFeature to the opposite of the default.

https://github.com/awslabs/aws-glue-schema-registry/blob/master/serializer-deserializer/src/main/java/com/amazonaws/services/schemaregistry/deserializers/json/JsonDeserializer.java#L67-L69

@clkelly-r7
Copy link
Author

I have written a fix for this if yous would like to see it

@bowen-s
Copy link
Contributor

bowen-s commented Feb 7, 2024

Thank you! PRs supporting this feature are welcomed.

@clkelly-r7
Copy link
Author

I don't currently have permission to push to this repo

@clkelly-r7
Copy link
Author

Pushed up fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants