You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, DownloadHandle has a join() function, but neither cp.rs or the benchmark runner bother to call it. It was added because UploadHandle has a join(), and we thought the APIs should be similar.
But DownloadHandle::join() cancels the download, while UploadHandle::join() waits for the upload to successfully complete, and has a separate UploadHandle::abort() function. Should we rename DownloadHandle::join() to DownloadHandle::abort()?
Also, what's the Drop behavior for DownloadHandle? We should probably ensure its spawned tasks get cancelled ASAP. Likewise for UploadHandle/UploadObjectsHandle/DownloadObjectsHandle
Drop and cancel for UploadHandle/UploadObjectsHandle (PR)
Drop and cancel for DownloadHandle/DownloadObjectsHandle
The text was updated successfully, but these errors were encountered:
Currently, DownloadHandle has a join() function, but neither cp.rs or the benchmark runner bother to call it. It was added because
UploadHandle
has a join(), and we thought the APIs should be similar.But
DownloadHandle::join()
cancels the download, whileUploadHandle::join()
waits for the upload to successfully complete, and has a separateUploadHandle::abort()
function. Should we renameDownloadHandle::join()toDownloadHandle::abort()
?Also, what's the
Drop
behavior forDownloadHandle
? We should probably ensure its spawned tasks get cancelled ASAP. Likewise forUploadHandle/UploadObjectsHandle/DownloadObjectsHandle
UploadHandle/UploadObjectsHandle
(PR)DownloadHandle/DownloadObjectsHandle
The text was updated successfully, but these errors were encountered: