Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AWS_ENDPOINT_URL_<SERVICE> #1213

Closed
2 tasks
1oglop1 opened this issue Nov 8, 2024 · 4 comments
Closed
2 tasks

Allow AWS_ENDPOINT_URL_<SERVICE> #1213

1oglop1 opened this issue Nov 8, 2024 · 4 comments
Labels
guidance Question that needs advice or information. p3 This is a minor priority issue

Comments

@1oglop1
Copy link

1oglop1 commented Nov 8, 2024

Describe the feature

Since there is already a support for AWS_ENDPOINT_URL #1193, I think the sdk should support all AWS_ENDPOINT_URL_<SERVICE> and other typical env vars.

https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-envvars.html#envvars-list-AWS_ENDPOINT_URL_SERVICE

Use Case

I run local dynamo DB from the amazon container but emulate other services with the localstack.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@1oglop1 1oglop1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2024
@aajtodd
Copy link
Contributor

aajtodd commented Nov 8, 2024

The SDK does support AWS_ENDPOINT_URL_<service>, can you provide an actual reproduction of something not working?

@aajtodd aajtodd added response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 7 days. and removed needs-triage This issue or PR still needs to be triaged. feature-request A feature should be added or improved. labels Nov 8, 2024
@jmklix jmklix added guidance Question that needs advice or information. p3 This is a minor priority issue labels Nov 8, 2024
@1oglop1
Copy link
Author

1oglop1 commented Nov 8, 2024

@aajtodd could you point me to the code that's responsible for this, it may be entirely possible I am a few versions behind because it is really difficult to keep the multiple versions in sync. I wish the entire SDK could have a single version to follow similarly to JS or Python.

I have these versions in a lockfile

name = "aws-config"
version = "1.1.9"
name = "aws-credential-types"
version = "1.1.8"
name = "aws-lc-rs"
version = "1.10.0"
name = "aws-lc-sys"
version = "0.22.0"
name = "aws-runtime"
version = "1.1.8"
name = "aws-sdk-cognitoidentityprovider"
version = "1.21.0"
name = "aws-sdk-dynamodb"
version = "1.20.0"
name = "aws-sdk-s3"
version = "1.21.0"
name = "aws-sdk-sqs"
version = "1.18.0"
name = "aws-sdk-ssm"
version = "1.20.0"
name = "aws-sdk-sso"
version = "1.18.0"
name = "aws-sdk-ssooidc"
version = "1.18.0"
name = "aws-sdk-sts"
version = "1.18.0"
name = "aws-sigv4"
version = "1.2.0"
name = "aws-smithy-async"
version = "1.2.1"
name = "aws-smithy-checksums"
version = "0.60.7"
name = "aws-smithy-eventstream"
version = "0.60.4"
name = "aws-smithy-http"
version = "0.60.7"
name = "aws-smithy-json"
version = "0.60.7"
name = "aws-smithy-query"
version = "0.60.7"
name = "aws-smithy-runtime"
version = "1.2.1"
name = "aws-smithy-runtime-api"
version = "1.3.0"
name = "aws-smithy-types"
version = "1.1.8"
name = "aws-smithy-types-convert"
version = "0.60.8"
name = "aws-smithy-xml"
version = "0.60.7"
name = "aws-types"
version = "1.1.8"

but here I found that it should indeed work

In my case

AWS_ENDPOINT_URL_DYNAMODB=http://localhost:5001 # does not work
AWS_ENDPOINT_URL=http://localhost:5001 # works

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 7 days. label Nov 8, 2024
@1oglop1
Copy link
Author

1oglop1 commented Nov 9, 2024

Okay I can confirm that, supports definitely AWS_ENDPOINT_URL_DYNAMODB

name = "aws-config"
version = "1.5.10"

@aajtodd thanks for the help. a bit OT, would you be able to guess what is preventing cargo update from updating AWS packages to the latest version? can it be any of the aws packages listed?

@1oglop1 1oglop1 closed this as completed Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants