Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): replace incorrect property checks in unit tests #1017

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore(all): replace incorrect property checks in unit tests #1017

merged 1 commit into from
Oct 4, 2023

Conversation

biffgaut
Copy link
Contributor

@biffgaut biffgaut commented Oct 4, 2023

replace

expect(construct.value !== null)

with

expect(construct.value).toBeDefined()

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 69d748b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

georgebearden
georgebearden approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@georgebearden georgebearden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@biffgaut biffgaut merged commit 4f4273d into main Oct 4, 2023
7 checks passed
@biffgaut biffgaut deleted the CorrectExpectStatements branch October 4, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgebearden georgebearden georgebearden approved these changes

@hayesry hayesry Awaiting requested review from hayesry hayesry is a code owner

@mobri2a mobri2a Awaiting requested review from mobri2a mobri2a is a code owner

@emcfins emcfins Awaiting requested review from emcfins emcfins is a code owner

@mickychetta mickychetta Awaiting requested review from mickychetta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biffgaut @aws-solutions-constructs-team @georgebearden