Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containsCreditCardNumber analyser constraint doesnt support for JCB credit card #533

Open
kakampassi opened this issue Feb 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kakampassi
Copy link

Describe the bug
containsCreditCardNumber analyser constraint doesnt support for JCB credit card

To Reproduce
// Visa, MasterCard, AMEX, Diners Club
val CREDITCARD: Regex = """\b(?:3[47]\d{2}([\ -]?)\d{6}\1\d|(?:(?:4\d|5[1-5]|65)\d{2}|6011)([\ -]?)\d{4}\2\d{4}\2)\d{4}\b""".r

The below two credit card doesnt belong to any of the above CC type. They belong to JCB credit card.
3566002020360505 , 3530111333300000

Expected behavior
It should support JCB credit card as well

Reference
https://github.com/awslabs/deequ/blob/master/src/main/scala/com/amazon/deequ/analyzers/PatternMatch.scala

@kakampassi kakampassi added the enhancement New feature or request label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant