addressing comments

awslabs · Nov 5, 2024 · 354f155 · 354f155
1 parent 6cf1e23
commit 354f155
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 26 deletions.
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -20,8 +20,7 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-    - name: Set up Python
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: 3.11
 

diff --git a/.github/workflows/doctests.yaml b/.github/workflows/doctests.yaml
@@ -15,8 +15,7 @@ jobs:
 
     steps:
     - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install other dependencies

diff --git a/.github/workflows/lints.yml b/.github/workflows/lints.yml
@@ -13,7 +13,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-python@v4
       with:
-          python-version: '3.12'
+          python-version: '3.11'
     - name: Install tools
       run: pip install "ruff==0.2.2" "docformatter[tomli]==1.5.0"
     - name: Ruff (Flake8)

diff --git a/.github/workflows/pypi.yml b/.github/workflows/pypi.yml
@@ -12,10 +12,9 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get tags
       run: git fetch --tags origin
-    - name: Set up Python
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
-        python-version: '3.12'
+        python-version: '3.11'
     - name: Install dependencies
       run: |
         python -m pip install -U pip

diff --git a/.github/workflows/tests-nixtla.yaml b/.github/workflows/tests-nixtla.yaml
@@ -8,15 +8,14 @@ jobs:
       max-parallel: 4
       fail-fast: false
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}
 
     steps:
     - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install other dependencies

diff --git a/.github/workflows/tests-nursery.yml b/.github/workflows/tests-nursery.yml
@@ -8,7 +8,7 @@ jobs:
       max-parallel: 1
       fail-fast: false
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}
@@ -17,8 +17,7 @@ jobs:
 
     steps:
     - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install MXNet (Linux)

diff --git a/.github/workflows/tests-prophet.yaml b/.github/workflows/tests-prophet.yaml
@@ -8,15 +8,14 @@ jobs:
       max-parallel: 4
       fail-fast: false
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}
 
     steps:
     - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install other dependencies

diff --git a/.github/workflows/tests-r.yml b/.github/workflows/tests-r.yml
@@ -8,7 +8,7 @@ jobs:
       max-parallel: 4
       fail-fast: false
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}
@@ -32,8 +32,7 @@ jobs:
           libxml2-dev \
           libcurl4-openssl-dev
         Rscript -e 'install.packages(c("forecast", "nnfor", "hts"), repos="https://cloud.r-project.org")'
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install Python dependencies

diff --git a/.github/workflows/tests-torch.yml b/.github/workflows/tests-torch.yml
@@ -8,7 +8,7 @@ jobs:
       max-parallel: 4
       fail-fast: false
       matrix:
-        python-version: ['3.9', '3.10']
+        python-version: ['3.9', '3.10', '3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}

diff --git a/.github/workflows/tests-xgboost.yaml b/.github/workflows/tests-xgboost.yaml
@@ -8,7 +8,7 @@ jobs:
       max-parallel: 4
       fail-fast: false
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -8,15 +8,14 @@ jobs:
       max-parallel: 4
       fail-fast: false
       matrix:
-        python-version: ['3.9', '3.10']
+        python-version: ['3.9', '3.10', '3.11']
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}
 
     steps:
     - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install other dependencies

diff --git a/test/torch/distribution/test_negative_binomial.py b/test/torch/distribution/test_negative_binomial.py
@@ -50,7 +50,7 @@ def test_custom_neg_bin_cdf(total_count, probs, value):
 @pytest.mark.parametrize("probs", [0.1, 0.5, 0.8])
 @pytest.mark.parametrize("total_count", [3, 7, 100])
 @pytest.mark.parametrize("value", [0.1, 0.5, 0.9])
-def test_custom_studentt_icdf(total_count, probs, value):
+def test_custom_neg_bin_icdf(total_count, probs, value):
     torch_dist = NegativeBinomial(total_count=total_count, probs=probs)
     scipy_dist = torch_dist.scipy_nbinom