[Hierarchical] Simplify computation of projection matrix using the standard summation matrix #2964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We can compute the projection matrix directly using the standard summation matrix
S
instead of the "constraint matrix"A
proposed in the paper.This form of projection matrix allows one to compare it with the other projection matrices used in the literature; essentially ours encapsulates all the linear reconciliation methods via the term
D
. Moreover, it also makes it clear that the reconciled forecasts are unbiased if the base forecasts are unbiased like the standard methods.Added a test that asserts that the two ways of computing the projection matrix are the same.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup