Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hierarchical] Simplify computation of projection matrix using the standard summation matrix #2964

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

rshyamsundar
Copy link
Contributor

@rshyamsundar rshyamsundar commented Aug 15, 2023

Issue #, if available:

Description of changes:

We can compute the projection matrix directly using the standard summation matrix S instead of the "constraint matrix" A proposed in the paper.

This form of projection matrix allows one to compare it with the other projection matrices used in the literature; essentially ours encapsulates all the linear reconciliation methods via the term D. Moreover, it also makes it clear that the reconciled forecasts are unbiased if the base forecasts are unbiased like the standard methods.

Added a test that asserts that the two ways of computing the projection matrix are the same.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@rshyamsundar rshyamsundar requested a review from melopeo August 16, 2023 12:13
@rshyamsundar rshyamsundar merged commit 6058ccb into awslabs:dev Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants