Add truncated normal distribution for torch distributions #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
reviewed
Aug 18, 2023
There was a problem hiding this comment.
@melopeo why does TruncatedNormal appear twice, both in distributions and distributions/utils?
Also what is the logic? Is this simply truncating samples between the bounds (when sampling) and raising errors for values outside the bounds when computing log density? Then maybe one could have a generic wrapper to apply to any distribution. (nevermind: I see there's more to it)
lostella
added
new feature
lostella
requested changes
Aug 22, 2023
melopeo
force-pushed
the
add_truncate_normal_distribution_for_torch_distributions
branch
from
e3c8dcc
to
c10f145
Compare
melopeo
force-pushed
the
add_truncate_normal_distribution_for_torch_distributions
branch
from
bf5953a
to
c072d92
Compare
lostella
reviewed
Aug 22, 2023
Co-authored-by: Lorenzo Stella <[email protected]>
lostella
approved these changes
Aug 22, 2023
melopeo
deleted the
add_truncate_normal_distribution_for_torch_distributions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add truncated normal distribution for torch distributions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup