Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loader for the M5 dataset #3151

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Fix loader for the M5 dataset #3151

merged 1 commit into from
Mar 24, 2024

Conversation

shchur
Copy link
Contributor

@shchur shchur commented Mar 23, 2024

Issue #, if available:

  • Fix loader for the M5 dataset

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@@ -61,6 +61,7 @@ def generate_m5_dataset(
"d",
],
axis=1,
errors="ignore",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to ignore errors?

@shchur shchur merged commit 722b9e6 into awslabs:dev Mar 24, 2024
19 checks passed
@shchur shchur deleted the fix-m5-loader branch March 24, 2024 06:41
@lostella lostella added the datasets This concerns dataset provided in the repository label May 24, 2024
kashif pushed a commit to kashif/gluon-ts that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets This concerns dataset provided in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants