Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RG changes seem to apply but don't propagate to resources #76

Open
candonov opened this issue Nov 1, 2024 · 0 comments
Open

RG changes seem to apply but don't propagate to resources #76

candonov opened this issue Nov 1, 2024 · 0 comments
Labels
area/runtime kind/bug Something isn't working

Comments

@candonov
Copy link
Collaborator

candonov commented Nov 1, 2024

Steps to reproduce:
Create a ResourceGroup with deployment, set imagePullPolicy to IfNotPresent:

          spec:
            serviceAccountName: ${spec.name}
            containers:
            - name: ${spec.name}
              image: ${spec.image}
              imagePullPolicy: IfNotPresent
              ports:
              - containerPort: ${spec.port}

Change the imagePullPolicy to Always and re-apply:

          spec:
            serviceAccountName: ${spec.name}
            containers:
            - name: ${spec.name}
              image: ${spec.image}
              imagePullPolicy: Always
              ports:
              - containerPort: ${spec.port}

Validate that the RG was updated:

❯ k get rg application.x.symphony.k8s.aws -o yaml| grep imagePullPolicy
              imagePullPolicy: Always

Create an instance and check the deployment:

❯ k get deployments.ap s3demo -o yaml |grep imagePull
        imagePullPolicy: IfNotPresent

Add a service account to the resource group:

  - name: serviceaccount
    definition:
      apiVersion: v1
      kind: ServiceAccount
      metadata:
        name: ${spec.name}
        namespace: ${spec.namespace}

Reapply the RG, create another instance, the new instance doesn't create a serviceaccount.

@candonov candonov changed the title bug: imagePullPolicy: Always doesn't propagate from rg to deployment bug: RG changes seem to apply but don't propagate to resources Nov 1, 2024
@a-hilaly a-hilaly added kind/bug Something isn't working area/runtime labels Nov 11, 2024
@a-hilaly a-hilaly changed the title bug: RG changes seem to apply but don't propagate to resources RG changes seem to apply but don't propagate to resources Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants