Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please, add option database port. #795

Open
gabin0801 opened this issue Sep 25, 2023 · 0 comments
Open

please, add option database port. #795

gabin0801 opened this issue Sep 25, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@gabin0801
Copy link

gabin0801 commented Sep 25, 2023

When setting up the kubeflow pipeline helm, it seems that the database port also needs to be set. (The database port is written as a constant.)
Due to rds security issues, db port setting is recommended.

for example(rds-s3 case),
change charts/apps/kubeflow-pipelines/rds-s3/values.yaml

rds:
  dbHost:
  mlmdDb:
s3:
  bucketName:
  minioServiceHost: s3.amazonaws.com
  minioServiceRegion:
  roleArn:

to

rds:
  dbHost:
  dbPort: ## add here
  mlmdDb:
s3:
  bucketName:
  minioServiceHost: s3.amazonaws.com
  minioServiceRegion:
  roleArn:

after then,
in charts/apps/kubeflow-pipelines/rds-s3/templates/ConfigMap/pipeline-install-config-kubeflow-ConfigMap.yaml files,

apiVersion: v1
data:
  ...
  dbHost: '{{ .Values.rds.dbHost }}'
  dbPort: '3306'

to

apiVersion: v1
data:
  ...
  dbHost: '{{ .Values.rds.dbHost }}'
  dbPort: '{{ .Values.rds.dbPort }}'

and after then,
in deployments/rds-s3/terraform/rds-s3-components/main.tf file,

module "filter_kfp_set_values" {
  source = "../../../../iaac/terraform/utils/set-values-filter"
  set_values = {
    "rds.dbHost"            = try(module.rds[0].rds_endpoint, null),
    "s3.bucketName"         = try(module.s3[0].s3_bucket_name, null),
    "s3.minioServiceRegion" = coalesce(var.minio_service_region, var.addon_context.aws_region_name)
    "rds.mlmdDb"            = var.mlmdb_name,
    "s3.minioServiceHost"   = var.minio_service_host
    "s3.roleArn"          = try(data.aws_iam_role.pipeline_irsa_iam_role[0].arn, null)
  }
}

to

module "filter_kfp_set_values" {
  source = "../../../../iaac/terraform/utils/set-values-filter"
  set_values = {
    "rds.dbHost"            = try(module.rds[0].rds_endpoint, null),
    "rds.dbPort" = try(module.rds[0].rds_port, null),  ## add here.
    "s3.bucketName"         = try(module.s3[0].s3_bucket_name, null),
    "s3.minioServiceRegion" = coalesce(var.minio_service_region, var.addon_context.aws_region_name)
    "rds.mlmdDb"            = var.mlmdb_name,
    "s3.minioServiceHost"   = var.minio_service_host
    "s3.roleArn"          = try(data.aws_iam_role.pipeline_irsa_iam_role[0].arn, null)
  }
}
@gabin0801 gabin0801 added the enhancement New feature or request label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant