tuftool: Allow specifying version in root init
#646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
reviewed
Aug 8, 2023
A new repo is created by calling `tuftool root init <path>`. It is a common pattern when renewing an expiring root to then have to call `tuftool root bump-version` multiple times or `tuftool root set-version`. Since this is so common, this change makes it possible to provide an option initial version to `root init` to avoid needing to run multiple commmands. This adds an optional `--version` or `-v` argument that can take a positive integer to set as the initial root version. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
root-init-version
branch
from
d75e889
to
265a261
Compare
etungsten
approved these changes
Aug 8, 2023
ecpullen
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
A new repo is created by calling
tuftool root init <path>. It is a common pattern when renewing an expiring root to then have to calltuftool root bump-versionmultiple times ortuftool root set-version.Since this is so common, this change makes it possible to provide an optional initial version to
root initto avoid needing to run multiple commmands. This adds an optional--versionargument that can take a positive integer to set as the initial root version.Testing done:
tuftool root init --helpoutput and verified correct help informationtuftool root init test.jsonand verified created successfully with the normal initial version of 1tuftool root init --version 5 test.jsonand verified created successfully with initial version set to 5By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.