Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cosmwasm dependencies #719

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fish-sammy
Copy link
Collaborator

@fish-sammy fish-sammy commented Dec 10, 2024

Description

Functional Changes

  • Trait KeyDeserialize added an associated type KEY_ELEMS, which represents "The number of key elements is used for the deserialization of compound keys. It should be equal to PrimaryKey::key().len().".
  • Several std storage types changed/removed the lifetime generic.
  • Some std error types changed.
  • The method .add_event takes Impl Into<Event> instead of Event now.
  • The Reply type added fields gas_used and payload, and the SubMsgResponse type added field msg_responses and deprecated data. However, the msg_response will only be filled after we upgrade core to use CosmWasm 2.0.

Testing Changes

  • MockApi now actually validates addresses. Therefore, all Addr::uncheck are replaced with MockApi::default().addr_make.
  • mock_info is deprecated in favour of message_info.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

e2e passed https://github.com/axelarnetwork/axelarate/actions/runs/12280119831

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 99.93041% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.53%. Comparing base (f6d97c7) to head (a4e5712).

Files with missing lines Patch % Lines
contracts/multisig/src/key.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   93.45%   93.53%   +0.07%     
==========================================
  Files         233      233              
  Lines       34849    35101     +252     
==========================================
+ Hits        32569    32831     +262     
+ Misses       2280     2270      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy force-pushed the chore/update-cosmwasm-libs branch 2 times, most recently from a102297 to 93de0d5 Compare December 10, 2024 03:00
@fish-sammy fish-sammy force-pushed the chore/update-cosmwasm-libs branch from 93de0d5 to a4e5712 Compare December 10, 2024 03:03
@fish-sammy fish-sammy marked this pull request as ready for review December 10, 2024 03:23
@fish-sammy fish-sammy requested a review from a team as a code owner December 10, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant