Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prettySymbol specific per token per chain #132

Open
4 tasks
ecdsafu opened this issue Sep 26, 2024 · 0 comments
Open
4 tasks

Make prettySymbol specific per token per chain #132

ecdsafu opened this issue Sep 26, 2024 · 0 comments

Comments

@ecdsafu
Copy link
Collaborator

ecdsafu commented Sep 26, 2024

Description

Currently ITS integrators can define prettySymbol at the top level per token. This should instead be set per token per chain.

If the prettySymbol isn’t defined for a particular chain, then the config export should default to the top-level symbol per chain.

Acceptance criteria

  • Add prettySymbol to be available within chains[n].prettySymbol
  • Remove prettySymbol at the top layer
  • Pretty symbol could be optional, or could default to symbol when using the generator script
  • Update wiki if necessary

Current config

{
      "tokenId": "0x6ce7a978114b2d34ee7b776ef36ee49c18752e35b7507c16994d5928332a6426",
      "deployer": "0x87e1237074760F57b424121edcA06F082700dBC2",
      "originalMinter": null,
      "prettySymbol": "NFTL",
      "decimals": 18,
      "originAxelarChainId": "ethereum",
      "tokenType": "interchain",
      "deploySalt": "0xdeead7ca2bddea93a28a9a71a5b53be2c9439b691fcaebf02fbf41f4ae78a528",
      "iconUrls": {
        "svg": "https://raw.githubusercontent.com/axelarnetwork/axelar-configs/main/images/tokens/nftl.svg"
      },
      "deploymentMessageId": "0x19f1e3cb4ce6c8e2a54764c86fe49bca583bbc2b4772190318445a2167121216-343",
      "chains": [
        {
          "symbol": "NFTL",
          "name": "Nifty League",
          "axelarChainId": "ethereum",
          "tokenAddress": "0x3c8D2FCE49906e11e71cB16Fa0fFeB2B16C29638",
          "tokenManager": "0x3150A2bA908A11eBE137B977C54c19bf971bb6c7",
          "tokenManagerType": "lockUnlock"
        },
        {
          "symbol": "NFTL",
          "name": "Nifty League",
          "axelarChainId": "immutable",
          "tokenAddress": "0xB0d7e9Ff5fb8E739c4990f7920d8047AcfAe4884",
          "tokenManager": "0x3150A2bA908A11eBE137B977C54c19bf971bb6c7",
          "tokenManagerType": "mintBurn"
        }
      ]
    },

Desired config

{
      "tokenId": "0x6ce7a978114b2d34ee7b776ef36ee49c18752e35b7507c16994d5928332a6426",
      "deployer": "0x87e1237074760F57b424121edcA06F082700dBC2",
      "originalMinter": null,
      "decimals": 18,
      "originAxelarChainId": "ethereum",
      "tokenType": "interchain",
      "deploySalt": "0xdeead7ca2bddea93a28a9a71a5b53be2c9439b691fcaebf02fbf41f4ae78a528",
      "iconUrls": {
        "svg": "https://raw.githubusercontent.com/axelarnetwork/axelar-configs/main/images/tokens/nftl.svg"
      },
      "deploymentMessageId": "0x19f1e3cb4ce6c8e2a54764c86fe49bca583bbc2b4772190318445a2167121216-343",
      "chains": [
        {
          "symbol": "NFTL",
          "prettySymbol": "NFTL.axl",
          "name": "Nifty League",
          "axelarChainId": "ethereum",
          "tokenAddress": "0x3c8D2FCE49906e11e71cB16Fa0fFeB2B16C29638",
          "tokenManager": "0x3150A2bA908A11eBE137B977C54c19bf971bb6c7",
          "tokenManagerType": "lockUnlock"
        },
        {
          "symbol": "NFTL",
          "prettySymbol": "NFTL.axl",
          "name": "Nifty League",
          "axelarChainId": "immutable",
          "tokenAddress": "0xB0d7e9Ff5fb8E739c4990f7920d8047AcfAe4884",
          "tokenManager": "0x3150A2bA908A11eBE137B977C54c19bf971bb6c7",
          "tokenManagerType": "mintBurn"
        }
      ]
    },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant