-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add agETH token #127
feat: add agETH token #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galacticminter, kindly add your logo/icon.
Hi @Olanetsoft, am I able to call these tokens on L2s as axl_agETH ? Is that convention fine ? |
Any reason for doing this? |
We have a canonical token called agETH or wagETH on these L2s. Wouldn't want axelar tokens to be called with the same name. @Olanetsoft |
@galacticminter I see. You can't rename the token Alternatively, if you have a UI, you can map the proposed name to the name on-chain, e.g., `"agETH": "axl_agETH," so that any time someone tries to load agETH, you can show on your UI the axl-prefixed name. |
Sounds good @Olanetsoft Could you please approve & merge this? |
@galacticminter, one last thing. Could you please add your coingecko id ? eg. "coinGeckoId": "your-id". See this reference |
@galacticminter on the Squid front end they'll be displayed using a prettySymbol, that we can edit as you like. Please let me know the preferred symbol on each chain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please use the pretty symbol as axl_agETH |
Sounds good. In Squid we are switching to the standard agETH.axl is that ok with you? We think it reads much better and is consistent with other bridge notations, such as USDC.e for ESDU bridged from ethereum native bridge |
@ecdsafu - Jake from our BD team confirmed with theirs that your proposal is okay. Do you need to reflect that symbol here or do you have a separate mapping elsewhere that does that? If the latter, I will merge this PR rn |
Friendly bump @ecdsafu ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the prettySymbol to be agETH.axl and then we can merge and release
Co-authored-by: Canh Trinh <[email protected]>
Adding Kelp's agETH config to whitelist on ITS.