Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

necessary fixes for addNativeGas method #239

Open
canhtrinh opened this issue Feb 1, 2023 · 0 comments
Open

necessary fixes for addNativeGas method #239

canhtrinh opened this issue Feb 1, 2023 · 0 comments

Comments

@canhtrinh
Copy link
Collaborator

canhtrinh commented Feb 1, 2023

  • accept a multipler in the AddGasOptiosn
  • take in the same gasLimit that was used in the first call for the tx (e.g. if estimateGasFee was originally invoked with 1mm gasLimit, then need to use 1mm gasLimit for addNativeGas)
  • determine how much gas to add based on where the tx is:
    • if it has already been approved and execution attempted, sdk should return full execution fee
    • if it has not already been approved and execution not attempted, sdk should subtract gas already paid by user
    • if it has already been confirmed (i.e. by axelerons), then subtract the original base fee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant