Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCidFromSrcTxHash function calculates incorrect commandId #313

Open
npty opened this issue Mar 25, 2024 · 0 comments
Open

getCidFromSrcTxHash function calculates incorrect commandId #313

npty opened this issue Mar 25, 2024 · 0 comments
Assignees

Comments

@npty
Copy link
Member

npty commented Mar 25, 2024

Description

This function returns the wrong command id for this transaction.

Expected Command Id: 0x79c7fed993d3ccbf52f5d05afd0839a03e7ae0ee61e9d7899025ce5be53e3ba4
Actual Command Id (wrong): 0x522921ffb053edf51d43d6c5ad0605c091c3cd37500c88a2e04a1b1cc66be550

Here's code snippet for quick reproducing an issue:

getCommandId.spec.ts

import { Environment } from "../../";
import { getCommandId } from "./getCommandId";
import rpcs from "../constants/chain";

describe("getCommandId", () => {
  test("should work", async () => {
    const commandId = getCommandId(
      "arbitrum",
      "0x3f1175cee93c64b77297a4a4d929d50b7b5e7904a2e1c80d3ce7b61ab0776de2",
      10,
      Environment.MAINNET,
      rpcs
    );

    console.log(commandId);
  });
});

I've also thoroughly tested with some other transactions as well below and observed inconsistencies in the returned data when compared to Axelarscan. Here's a breakdown:

✅ Confirmed Matches:

❌ Discrepancies:

@npty npty self-assigned this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant