Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add minter check #276

Merged
merged 6 commits into from
Sep 9, 2024
Merged

fix: add minter check #276

merged 6 commits into from
Sep 9, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Sep 7, 2024

AXE-4774

  • Require to add check that the minter isn’t equal to ITS.
  • Added test coverage.

@ahramy ahramy requested a review from a team as a code owner September 7, 2024 00:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (4653197) to head (88b40e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   97.68%   97.69%           
=======================================
  Files          19       19           
  Lines         606      608    +2     
  Branches      123      125    +2     
=======================================
+ Hits          592      594    +2     
  Misses          5        5           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/InterchainTokenFactory.sol Outdated Show resolved Hide resolved
contracts/InterchainTokenFactory.sol Show resolved Hide resolved
contracts/InterchainTokenFactory.sol Outdated Show resolved Hide resolved
contracts/InterchainTokenFactory.sol Outdated Show resolved Hide resolved
@ahramy ahramy merged commit 2b07e70 into main Sep 9, 2024
5 checks passed
@ahramy ahramy deleted the fix/minter_check branch September 9, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants