Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unit tests for halo2-wasm #40

Merged
merged 11 commits into from
Nov 8, 2023
Merged

feat: add unit tests for halo2-wasm #40

merged 11 commits into from
Nov 8, 2023

Conversation

rpalakkal
Copy link
Contributor

No description provided.

jonathanpwang
jonathanpwang approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small nits and suggestions, but overall looks great!

halo2-wasm/.cargo/config.toml Show resolved Hide resolved
halo2-wasm/src/tests/gate.rs Outdated Show resolved Hide resolved
halo2-wasm/src/tests/gate.rs Outdated Show resolved Hide resolved
halo2-wasm/src/tests/gate.rs Outdated Show resolved Hide resolved
halo2-wasm/src/tests/range.rs Outdated Show resolved Hide resolved
halo2-wasm/src/tests/gate.rs Show resolved Hide resolved
halo2-wasm/src/tests/range.rs Show resolved Hide resolved
@rpalakkal rpalakkal merged commit 5f67a3b into main Nov 8, 2023
1 check passed
@rpalakkal rpalakkal deleted the feat/wasm-unit-tests branch November 8, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpalakkal @jonathanpwang