Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench zkevm_hashes keccak with mv_lookup (logup) #199

Open
jonathanpwang opened this issue Oct 26, 2023 · 0 comments
Open

Bench zkevm_hashes keccak with mv_lookup (logup) #199

jonathanpwang opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jonathanpwang
Copy link
Contributor

Requires using a fork of axiom-crypto/halo2 that merges https://github.com/han0110/halo2/commits/feature/logup and then benchmarking

halo2-lib/hashes/zkevm/src/keccak/vanilla/tests.rs

Line 243 in 980b39b

#[test_case(18, 9 ; "k: 18, rows_per_round: 9")]
with and without using the fork.
@jonathanpwang jonathanpwang added enhancement New feature or request help wanted Extra attention is needed labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanpwang and others