Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better failure modes for mussel acceptance tests #714

Open
triggers opened this issue Aug 25, 2015 · 1 comment
Open

Better failure modes for mussel acceptance tests #714

triggers opened this issue Aug 25, 2015 · 1 comment

Comments

@triggers
Copy link
Member

Problem:

Mussel acceptance tests continue to execute, even after fatal error
has already occurred. This can be seen in the following test, which
continues to execute even when $DCMGR_HOST is not set correctly. The
test should stop after the first call to curl can not reach dcmgr.
Other tests probably have this same problem.

wakame-vdc/client/mussel/test/acceptance/v12.03/windows-instance/t.instance.base.sh

Solution:

Not sure. Need to look at the current exception framework and see if
it is being used, and perhaps just use it more effectively. Or maybe
some new exception strategy or framework would be worth implementing.
For one test, this may not be worth fixing. On the other
hand, a clean solution could have other side benefits: (faster mussel
client, better error messages, cleaner logs, better Jenkins slave
utilization)

@triggers
Copy link
Member Author

For example, even though curl fails almost immediately in the test, the script continues for
another 4 minutes:

/ssh:lxc32: #$ export DCMGR_HOST=bad.dcmgr.ip.address
/ssh:lxc32: #$ time hypervisor=kvm image_id=wmi-windows2008r2 ./t.instance.base.sh
curl: (6) Couldn't resolve host 'bad.dcmgr.ip.address'

output_keyfile=./../../../helpers/key_pair.7038
Generating public/private rsa key pair.
Your identification has been saved in ./../../../helpers/key_pair.7038.
Your public key has been saved in ./../../../helpers/key_pair.7038.pub.
The key fingerprint is:
ef:5f:92:1f:9f:e9:1f:bb:59:96:d6:78:24:d7:86:6f ./../../../helpers/key_pair.7038
The key's randomart image is:
+--[ RSA 2048]----+
|                 |
|                 |
|                 |
|               ..|
|        S     o =|
|         .   . Bo|
|          . o ++E|
|         .   +.*B|
|          ... oB=|
+-----------------+
curl: (6) Couldn't resolve host 'bad.dcmgr.ip.address'

curl: (6) Couldn't resolve host 'bad.dcmgr.ip.address'

curl: (6) Couldn't resolve host 'bad.dcmgr.ip.address'
[ERROR] 'uuid' is empty (functions:175)
test_get_instance_ipaddr
[ERROR] 'uuid' is empty (functions:175)
test_wait_for_network_to_be_ready
Usage: ping [-LRUbdfnqrvVaA] [-c count] [-i interval] [-w deadline]
            [-p pattern] [-s packetsize] [-t ttl] [-I interface or address]
            [-M mtu discovery hint] [-S sndbuf]
            [ -T timestamp option ] [ -Q tos ] [hop1 ...] destination
[2015-08-25T03:31:04 PM #7038] time:1 eval:
Usage: ping [-LRUbdfnqrvVaA] [-c count] [-i interval] [-w deadline]
            [-p pattern] [-s packetsize] [-t ttl] [-I interface or address]
            [-M mtu discovery hint] [-S sndbuf]
            [ -T timestamp option ] [ -Q tos ] [hop1 ...] destination
....deleted.....
....deleted.....
Retry Failure: Exceed 120 sec: Retried 41 times
ASSERT:expected:<0> but was:<1>
test_wait_for_rdpd_to_be_ready
usage: nc [-46DdhklnrStUuvzC] [-i interval] [-p source_port]
      [-s source_ip_address] [-T ToS] [-w timeout] [-X proxy_version]
      [-x proxy_address[:port]] [hostname] [port[s]]
[2015-08-25T03:33:07 PM #7038] time:1 eval:
usage: nc [-46DdhklnrStUuvzC] [-i interval] [-p source_port]
      [-s source_ip_address] [-T ToS] [-w timeout] [-X proxy_version]
      [-x proxy_address[:port]] [hostname] [port[s]]
....deleted.....
....deleted.....
Retry Failure: Exceed 120 sec: Retried 40 times
ASSERT:expected:<0> but was:<1>
test_rdp_auth
[ERROR] 'ssh_key_file' is incorrect (instance.sh:140)
ASSERT:expected:<0> but was:<1>
plain_password=''
ASSERT:expected:<0> but was:<131>
[ERROR] 'uuid' is empty (functions:200)
curl: (6) Couldn't resolve host 'bad.dcmgr.ip.address'
[ERROR] 'uuid' is empty (functions:200)
[ERROR] 'uuid' is empty (functions:200)

Ran 4 tests.

FAILED (failures=4)

real    4m8.675s
user    0m0.802s
sys 0m0.679s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants