Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make llvm-objcopy path configurable via environment variable in test/integration-test/build.rs #1142

Open
ignacya opened this issue Jan 22, 2025 · 0 comments · May be fixed by #1143
Open

Make llvm-objcopy path configurable via environment variable in test/integration-test/build.rs #1142

ignacya opened this issue Jan 22, 2025 · 0 comments · May be fixed by #1143

Comments

@ignacya
Copy link

ignacya commented Jan 22, 2025

The test/integration-test/build.rs file currently has the name of the llvm-objcopy executable hard-coded. Allowing it to be overridden by the environment would make running these tests more flexible.
ignacya added a commit to ignacya/aya that referenced this issue Jan 22, 2025
@ignacya
integration-test: read OBJCOPY from the environment with fallback
e1639f5 
Check for the OBJCOPY environment variable and fall back to
`"llvm-objcopy"` if it's not set.

Simplifies running integration tests while mantaining backward
compatibility.

Fixes: aya-rs#1142
ignacya added a commit to ignacya/aya that referenced this issue Jan 22, 2025
@ignacya
integration-test: read OBJCOPY from the environment with fallback
cefee7e 
Check for the OBJCOPY environment variable and fall back to
`"llvm-objcopy"` if it's not set.

Simplifies running integration tests while maintaining backward
compatibility.

Fixes: aya-rs#1142
@ignacya ignacya linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

integration-test: read OBJCOPY from the environment with fallback ignacya/aya
1 participant
@ignacya