Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Context menu not showing until refresh the page and it's not desapear after changing page #2

Closed
saifonglee opened this issue Apr 28, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@saifonglee
Copy link

What happened?

  1. the contextMenu appear correctly when refresh the page. but if i come to the page without refreshing it, the contextMenu not showing.
  2. when i click link on the contextMenu to change page, in the targeted page, i have to refresh before seing the conextMenu. and the contextMenu do not disapear when go back to the previous page even if i click on Esc key or refresh the page.

How to reproduce the bug

  1. add the PageHasContextMenu to the page
  2. add the getContextMenuActions function and set the contextMenu actions
  3. test on the targeted pages.

Package Version

1.0.0

PHP Version

8.2.17

Laravel Version

10.x

Which operating systems does with happen with?

Linux

Notes

No response

@saifonglee saifonglee added the bug Something isn't working label Apr 28, 2024
@aymanalhattami
Copy link
Owner

Check browser console to see if there is an error

@saifonglee
Copy link
Author

Capture d’écran du 2024-04-29 09-45-34

@aymanalhattami
Copy link
Owner

These errors not related to the package

@saifonglee
Copy link
Author

so there is no error, but it still not workong well. i've to refresh the page to be able to see the contextMenu

@zajinx
Copy link

zajinx commented May 7, 2024

I think this happens only in SPA mode, if I enable it when I navigate from a page without context menu enable to one with context menu it doesn't load up, but if access the page directly it works no problem

@aymanalhattami
Copy link
Owner

PRs are welcome

@JoshuaSigaban
Copy link
Contributor

Yes @zajinx looks like the issue is when using ->spa()
Also experiencing the same issue

@aymanalhattami
Copy link
Owner

fixed #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants