-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DB): clarify IDs for faction changes #20480
Open
TheSCREWEDSoftware
wants to merge
6
commits into
azerothcore:master
Choose a base branch
from
TheSCREWEDSoftware:FactionChangeComments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(DB): clarify IDs for faction changes #20480
TheSCREWEDSoftware
wants to merge
6
commits into
azerothcore:master
from
TheSCREWEDSoftware:FactionChangeComments
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "comments" for the achivements of each faction equivalent.
The PR is ready to be review ? |
Yes it is |
Grimdhex
approved these changes
Nov 15, 2024
Grimdhex
changed the title
fix(DB/player_factionchange_achievement & "quests & "reputations)
fix(DB): clarify IDs for faction changes
Nov 15, 2024
there was still an ongoing discussion about this in discord iirc. |
Grimdhex
added
To Be Merged - Later
This PR promotes delicate changes and has been flagged to be merged after the holiday seasons.
and removed
To Be Merged
labels
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DB
related to the SQL database
To Be Merged - Later
This PR promotes delicate changes and has been flagged to be merged after the holiday seasons.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Tables:
player_factionchange_achievement
player_factionchange_quests
player_factionchange_reputations
Are having their tables drop and created to add the new comment column and their respective data.
This PR proposes changes to:
Issues Addressed:
SOURCE:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
player_factionchange_achievement
player_factionchange_quests
player_factionchange_reputations