Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonize XEventTransition system code #157

Open
azriel91 opened this issue Mar 12, 2020 · 0 comments
Open

Commonize XEventTransition system code #157

azriel91 opened this issue Mar 12, 2020 · 0 comments
Labels
M: code Code maintenance and quality.
Milestone

Comments

@azriel91
Copy link
Owner

In GitLab by @azriel91 on Aug 23, 2019, 11:09

There is an emerging pattern for transition systems, of the form:

  • XyzTransitionSystem is a transitions system that reads XEvents, and determines which sequence to transition to based on XTransition.
  • There may be multiple XTransitions, which may be skipped if their (optional) requirement is not met.
  • The requirements need to read other Component values from the entity to determine if they are met.

Table:

System Subscribed event channel Transition type
CharacterControlTransitionsTransitionSystem ControlInputEvent CharacterControlTransition
HitEffectTransitionSystem HitEvent HitTransition
HittingEffectTransitionSystem HitEvent HittingTransition
CharacterHitEffectSystem HitEvent CharacterHitTransition

It is likely this pattern is going to be further used, and so generic code should be written to reduce the duplicated semantics of these types and logic.

@azriel91 azriel91 added the M: code Code maintenance and quality. label Mar 12, 2020
@azriel91 azriel91 added this to the Backlog milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: code Code maintenance and quality.
Projects
None yet
Development

No branches or pull requests

1 participant