Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize System Tests #174

Open
azriel91 opened this issue Mar 12, 2020 · 3 comments
Open

Parallelize System Tests #174

azriel91 opened this issue Mar 12, 2020 · 3 comments
Labels
M: builds Build, test, and deployment maintenance.
Milestone

Comments

@azriel91
Copy link
Owner

In GitLab by @azriel91 on Oct 5, 2019, 08:54

Many tests currently load textures, and in rendy#151, using rendy in multiple threads at the same time causes a segfault. Using a mutex slows down testing a lot.

We can speed the tests up by not loading textures for Systems that simply need an AssetId and some components, instead of using AutexousiousApplication::config_base() or AutexousiousApplication::game_base()

@azriel91 azriel91 added the M: builds Build, test, and deployment maintenance. label Mar 12, 2020
@azriel91 azriel91 added this to the Backlog milestone Mar 12, 2020
@azriel91
Copy link
Owner Author

In GitLab by @azriel91 on Oct 22, 2019, 11:54

Simply changing run_isolated() calls to run() worked. Perhaps underlying libraries or drivers were fixed to no longer have issues with running the tests in parallel.

Deferring re-organization of loading code in tests to a later date.

@azriel91
Copy link
Owner Author

In GitLab by @azriel91 on Oct 23, 2019, 09:40

unassigned @azriel91

@azriel91
Copy link
Owner Author

In GitLab by @azriel91 on Nov 7, 2019, 11:53

Perhaps introduce environmental / configuration flags that the asset part loaders read. Then even with SpriteRefs exist, they may choose to not load SpriteRenderSequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: builds Build, test, and deployment maintenance.
Projects
None yet
Development

No branches or pull requests

1 participant