Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SystemBundles and add Systems directly #181

Open
azriel91 opened this issue Mar 12, 2020 · 0 comments
Open

Remove SystemBundles and add Systems directly #181

azriel91 opened this issue Mar 12, 2020 · 0 comments
Labels
M: code Code maintenance and quality.
Milestone

Comments

@azriel91
Copy link
Owner

In GitLab by @azriel91 on Oct 31, 2019, 15:57

Bundles currently provide two functionalities:

  • Group systems, and add them together.
  • Add resources to the World.

However, the use of bundles also makes it difficult to specify system dependencies, as the bundle would need to take in / output the names of the systems. As such, most bundles do not do this, and so most systems are run in any order.

We may use bundles for adding resources, but we should look at adding Systems to the dispatcher (via GameDataBuilder) without SystemBundles.

If Amethyst switches to Legion, we may use that migration opportunity to also do this.

Related: #138

@azriel91 azriel91 added the M: code Code maintenance and quality. label Mar 12, 2020
@azriel91 azriel91 added this to the Backlog milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: code Code maintenance and quality.
Projects
None yet
Development

No branches or pull requests

1 participant