Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SequenceIdMappings loading #187

Open
azriel91 opened this issue Mar 12, 2020 · 0 comments
Open

Consolidate SequenceIdMappings loading #187

azriel91 opened this issue Mar 12, 2020 · 0 comments
Labels
M: code Code maintenance and quality.
Milestone

Comments

@azriel91
Copy link
Owner

azriel91 commented Mar 12, 2020

In GitLab by @azriel91 on Nov 29, 2019, 12:10

  • AssetType::Object(..) and AssetType::Map store SequenceIdMappings in AssetSequenceIdMappings, as they only have one ItemId.

    This must be done prior to loading SpawnsSequenceHandles in AssetSequenceComponentLoadingSystem, as objects need to know the sequence ID of the objects they are spawning.

  • AssetType::Ui loads SequenceIdMappings in AssetSequenceComponentLoadingSystem, as the SequenceIds need to be per BackgroundDefinition or UiDefinition for the indices in sequence component data (e.g. WaitSequenceHandles) to be correct.

This disparity works for now, but may be confusing. The difficulty in shifting the SequenceIdMappings loading for Objects is, Spawns can map from the AssetSlug in spawn config to AssetId, but not to an ItemId / SequenceId within that AssetId -- and ItemId does not exist until after AssetSequenceComponentLoadingSystem has run.

@azriel91 azriel91 added the M: code Code maintenance and quality. label Mar 12, 2020
@azriel91 azriel91 added this to the Backlog milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: code Code maintenance and quality.
Projects
None yet
Development

No branches or pull requests

1 participant