Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Improve depends_on: support #383

Open
madejackson opened this issue Jan 15, 2025 · 0 comments
Open

[FEAT]: Improve depends_on: support #383

madejackson opened this issue Jan 15, 2025 · 0 comments

Comments

@madejackson
Copy link
Contributor

madejackson commented Jan 15, 2025

Feature Description

Since 0.16, depends_on: in compose is supported / gets translated into cosmos-compose (almost bug free). Unfortunately, as its function is limited. I think it does make sense to support it fully to keep your apps running and not dying silently.

Does anyone knows the state of depends_on: support?
From my testing, it is usable (with or without args) but there are several issues:

  • when using via compose-import restart: true get's converted to "restart": true but cosmos-compose expects "restart": "true" (notice the str instead of bool)
  • when depending on a service but not listing the service in the same command, the creation fails (even when the service is already up and running)
  • after creation, the cosmos-compose does not list any depends_on: values anymore. It seems the use of depends_on is limited to creation time. Therefore when a service is already installed and gets updated (recreated) or restarted, depends_on is ignored hence possibly breaking things which are depending on this to work

https://discord.com/channels/1083875833824944188/1166053681079259257/1326105399757115413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant