Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win][g++] Remaken rules .pri files not found with qmake -spec win32-g++ #11

Open
jim-bcom opened this issue Dec 22, 2022 · 2 comments
Open
Assignees
Milestone

Comments

@jim-bcom
Copy link

HOW TO REPRODUCE

  • git clone https://github.com/SolarFramework/SolARFramework
  • Remove win32 compiler options from .pro file as MSVC is expected
  • mkdir build && cd build
  • qmake ..\SolARFramework.pro -spec win32-g++

EXPECTED BEHAVIOR

  • Project MESSAGE: Remaken qmake build rules used : C:/Users/user/.remaken/rules/qmake (obtained with -spec win32-msvc)
  • Continues configuration

OBSERVED BEHAVIOR

  • Some .pri files are not found due to badly formatted path
Project MESSAGE: Remaken qmake build rules used :  C:/Users/user/.remaken/rules/qmake
Cannot read C:/C/Users/user/.remaken/rules/qmake/templatelibconfig.pri: No such file or directory
Cannot read C:/C/Users/user/.remaken/rules/qmake/remaken_install_target.pri: No such file or directory
Project MESSAGE: Remaken qmake build rules used :  C:/Users/user/.remaken/rules/qmake
Project MESSAGE: Remaken qmake build rules used :  C:/Users/user/.remaken/rules/qmake
  • From a project located on D:\, the erroneous paths become D:/C/Users/user/.remaken/rules/qmake/*.pri
  • May cause compilation error (missing third party lib headers due to lack of -I on CLI) (?)
> jom

jom 1.1.3 - empower your cores

        C:\Qt\Tools\QtCreator\bin\jom.exe -f Makefile.Release
        g++ -c -fno-keep-inline-dllexport -O2 -std=gnu++1z -Wall -Wextra -Wextra -fexceptions -mthreads -DUNICODE -D_UNICODE -DWIN32 -DMINGW_HAS_SECURE_API=1 -DMYVERSION=0.11.0 -DTEMPLATE_LIBRARY -D_NDEBUG=1 -DNDEBUG=1 -DQT_NEEDS_QMAIN -IC:/Users/user/tmp/SolARFramework -I. -IC:/Users/user/tmp/SolARFramework/interfaces -IC:/Qt/5.14.2/msvc2017_64/mkspecs/win32-g++ -o release/Log.o C:/Users/user/tmp/SolARFramework/src/core/Log.cpp
In file included from C:/Users/user/tmp/SolARFramework/src/core/Log.cpp:1:
C:/Users/user/tmp/SolARFramework/interfaces/core/Log.h:7:10: fatal error: spdlog.h: No such file or directory
 #include "spdlog.h"
          ^~~~~~~~~~
compilation terminated.

OS: Windows 10
Remaken version: 1.9.2
BD/Qmake version: 4.9.3

@stefled
Copy link
Collaborator

stefled commented Dec 20, 2023

reproduced with :

  • Windows 10
  • BD/Qmake 4.10.0
  • Kit Qt 6.6.1 - MinGw 11.2.0 64bit
  • Conan 1.59.0 profile :

[settings]
os=Windows
os_build=Windows
arch=x86_64
compiler=gcc
compiler.cppstd=17
compiler.version=11.2
compiler.libcxx=libstdc++11
build_type=Release
arch_build=x86_64
[options]
[build_requires]
[env]

BD/Qmake needs to manage gcc/g++ and not only msvc.
Remaken tool potentially also needs to be updated to handle gcc/g++ on Windows

stefled added a commit that referenced this issue Dec 20, 2023
@stefled
Copy link
Collaborator

stefled commented Dec 20, 2023

a fix was added to differentiate with the win32-msvc case

will be available in a next release

@stefled stefled self-assigned this Dec 20, 2023
@stefled stefled added this to the 4.11.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants