Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improve visibility of error relative to missing pkg-config tool #14

Open
jim-bcom opened this issue Nov 30, 2023 · 1 comment
Assignees
Milestone

Comments

@jim-bcom
Copy link

PROBLEM

  • from a fresh environment, install remaken (brew install remaken)
  • run init and profile commands
  • be sure to not have pkg-config installed
  • run qmake on a project with remaken deps that require the use of pkg-config (spdglog, xpcf,...).

The problem is that the command seems to have run without error.

When make is invoked to compile the project, the library's header files (e.g. xpcf) are not found, and this library is nowhere to be found on the compiler command line.

When looking more closely at the qmake command logs, we can see indications that something went wrong:

  • pkg-config is not found:
 Project MESSAGE: ---- Processing spdlog 0.14.0 package ----
/bin/sh: 1: pkg-config: not found
/bin/sh: 1: pkg-config: not found
  • include dirs are empty:
Project MESSAGE: ----------------------------------------------------------------
Project MESSAGE: ---- Global processing result 
Project MESSAGE:   --> [INFO] QMAKE_CXXFLAGS : 
Project MESSAGE:   -pipe
Project MESSAGE:   --> [INFO] INCLUDEPATH : 
Project MESSAGE:   
Project MESSAGE:   --> [INFO] LIBS : 
Project MESSAGE: 

Although, the sh error is explanatory, time can be lost looking for what actually happened.

SUGGESTED SOLUTION

  • Handle the sh error,stop execution of qmake command and give an error message and instructions on how to resolve the issue (i.e. install pkg-config).
  • (Add a kind of brew doctor command to remaken to make some checks about the environement. But maybe here it's not relevant, becausepkg-config is maybe not needed if the project only uses conan dependencies, for example, right?)

CONFIGURATION
OS: Ubuntu-22.04
remaken: 1.9.4
builddefs-qmake: 4.9.5

@stefled
Copy link
Collaborator

stefled commented Dec 19, 2023

A fix has been added :
Qmake returns an error when pkg-config is needed but not found

will be available in a next release

@stefled stefled added this to the 4.11.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants