Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sorting for translations in container v3.x #572

Closed
DenisMir opened this issue Jan 14, 2025 · 1 comment · Fixed by #574
Closed

Incorrect sorting for translations in container v3.x #572

DenisMir opened this issue Jan 14, 2025 · 1 comment · Fixed by #574

Comments

@DenisMir
Copy link

DenisMir commented Jan 14, 2025

TYPO3: 13.4.2 (or 12.4.24)
Container: 3.1.1

We recognized incorrect sorting values on translations in free mode (this is important). This problem only exists for container 3.x! (on 2.x it works)

We had a similar issue that was fixed for 2.x in the past: #425. But in this case the reason for the error seems not to be the same.

Here is an example on how to reproduce the error.

  • Create a container A
  • Nest container B in container A
  • Create child element CH1 in container B
  • Create child element CH2 in container B (below CH1)
  • Nest container C in container A (below container B)
  • Create child element CH3 in container C

This results in the database as:

uid colPos tx_container_parent sys_language_uid sorting HEADER
8 0 0 0 256 A
9 200 8 0 512 B
10 200 9 0 768 CH1
11 200 9 0 1024 CH2
12 200 8 0 1280 C
13 200 12 0 1536 CH3

Now translate copy (free mode) the page. And you will get in the database:

uid colPos tx_container_parent sys_language_uid sorting HEADER
14 0 0 1 1792 A
17 200 14 1 1920 B
18 200 17 1 1984 CH2
19 200 17 1 2016 CH1
15 200 14 1 2048 C
16 200 15 1 2304 CH3

So the sorting of CH1 and CH2 is incorrect now in the translation.

This is how it looks in the backend page module:

Bildschirmfoto 2025-01-14 um 10 40 44

@DenisMir DenisMir changed the title Incorrect sorting values on nested containers lead to incorrect translations (sorting broken) - back in 3.x Incorrect sorting for translations in container v3.x Jan 14, 2025
achimfritz added a commit that referenced this issue Jan 18, 2025
when adding support for v13 condition with t3_origuid in
datahandler hook was removed because TYPO3 dropped t3_origuid field

this patch readds condition with l10n_source field instead of t3_origuid field

Fixes: #572
achimfritz added a commit that referenced this issue Jan 18, 2025
when adding support for v13 condition with t3_origuid in
datahandler hook was removed because TYPO3 dropped t3_origuid field

this patch readds condition with l10n_source field instead of t3_origuid field

Fixes: #572
achimfritz added a commit that referenced this issue Jan 24, 2025
when adding support for v13 condition with t3_origuid in
datahandler hook was removed because TYPO3 dropped t3_origuid field

this patch readds condition with l10n_source field instead of t3_origuid field

Fixes: #572
@DenisMir
Copy link
Author

Thank you very much for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant