Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R/finality contract #65

Merged
merged 51 commits into from
Sep 25, 2024
Merged

R/finality contract #65

merged 51 commits into from
Sep 25, 2024

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Sep 16, 2024 •
edited
Loading

Part of #11. Closes #52.

TODO:

  • babylon-finality contract based on the finality module.
  • Refactor storage access to (smart) queries.
  • Refactor (batched) active finality provider set computation.
  • babylon-finality sudo handlers.
  • (Cascaded) babylon-finality instantiation logic.
  • Config and Params handling.
  • Convert required unit test to multi-tests.
  • full-validation feature path.

@maurolacy maurolacy marked this pull request as draft September 16, 2024 08:34
@maurolacy maurolacy self-assigned this Sep 16, 2024
Base automatically changed from r/index-btc-height to main September 17, 2024 05:23
Mauro Lacy added 21 commits September 18, 2024 09:16
Move active fps calca to finality mod
21760a8
Fix: Non-zero fp voting power check
7892932
Move FP_SET to finality state where it belongs
ab5e5ea
Split staking and finality execution handlers
12f826d
Move finality stuff out of btc-staking and into babylon-finality
5ee7987
Add babylon-finality contract (WIP)
c56df77
Fix rebase errors
806409e
Remove sudo handlers from the staking contract
44f1919
Add staking slash handler / msg
3177ada
Refactor: use staking queries, and batched active FPs processing
065e1ef
cargo fmt
b09b542
Add babylon contract version to store in passing
262b4a4
Add finality contract instantiation
63cdd1f
Remove finality dependendency
4b6bd78
Rename to btc-finality for consistency
feed346
Refactor: route slashing through babylon only
246ea4b
Fix: proper routing / auth of slashing message
a145f7e
Update / Set staking address during finality contract instantiation
7d4c030
Fix / adapt benches
16e94f5
Improve / adjust size checks
066ea79
Fix / adjust staking tests
49b6ec8
Remove unused structs
3562f8b 
Update schema
@maurolacy maurolacy marked this pull request as ready for review September 18, 2024 10:27
SebastianElvis
SebastianElvis approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

contracts/btc-finality/src/state/config.rs Show resolved Hide resolved
contracts/btc-finality/src/finality.rs Outdated Show resolved Hide resolved
@maurolacy maurolacy merged commit 70b6af6 into main Sep 25, 2024
2 checks passed
@maurolacy maurolacy deleted the r/finality-contract branch September 25, 2024 13:45
This was referenced Sep 26, 2024
Closed
Merged
maurolacy added a commit that referenced this pull request Sep 27, 2024
@maurolacy
Fix/optimizer (#72)
a7cd058 
#65 small fix / follow-up.

Gates `library` feature included code not to be in the final wasm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@gusin13 gusin13 Awaiting requested review from gusin13

Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: split BTC staking contract and finality contract
2 participants
@maurolacy @SebastianElvis