Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/optimizer #72

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Fix/optimizer #72

merged 9 commits into from
Sep 27, 2024

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Sep 27, 2024

#65 small fix / follow-up.

Gates library feature included code (test code, basically), so that it's only included for tests and not the final wasm.
The need for this seems to arise from a limitation or particularity of the test config setting, which is not being propagated or set during inclusion of other code. Perhaps this is correct, as setting it could render that code unavailable (or different).

I don't know, more investigation would be needed to clarify / understand this better.

In the mean time, this is a (somewhat involved) way to solve / workaround this issue.

Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@maurolacy maurolacy merged commit a7cd058 into main Sep 27, 2024
2 checks passed
@maurolacy maurolacy deleted the fix/optimizer branch September 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants