Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore now unsupported integration test #86

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Ignore now unsupported integration test #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/btc-finality/tests/integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ fn wasm_size_limit_check() {
}

#[test]
#[ignore = "Unsupported query type: GRPC"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you give more context about this one?

Copy link
Contributor Author

@maurolacy maurolacy Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mocked environment in which integration tests run don't support these queries. Since this query is now part of the finality contract instantiation, the instantiation integration test fails.

There's no easy way around this, except disabling or removing the test, as these integration tests are run against the optimised wasm binary that is going to be released.

fn instantiate_works() {
let mut deps = mock_instance(WASM, &[]);

Expand Down