feat: add a CI workflow to publish the bitcoinsim image #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap2pecs
reviewed
Oct 19, 2024
| @@ -23,7 +23,7 @@ if [[ ! -d "$BITCOIN_DATA" ]]; then | |||
| fi | |||
| echo "Generating bitcoin.conf file at $BITCOIN_CONF" | |||
| if [[ "$BITCOIN_NETWORK" == "testnet" ]]; then | |||
| NETWORK_LABEL="test" | |||
| NETWORK_LABEL="test" # [test] not [testnet] for testnet3 | |||
There was a problem hiding this comment.
this comment said for the Bitcoin network we need to set test for testnet3 in the bitcoin.conf.
anyway, we can remove it since we only support signet now.
There was a problem hiding this comment.
where is bitcoin.conf? i cannot find it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a CI workflow that publishes the
bitcoinsimdocker image when changes are made to thecontrib/images/bitcoindsim/directory.Test Plan
Update the
Dockerfileorwrapper.shand thenbitcoindsimimage should be published to the Babylon docker hub.