BTC Wallet: Keystone initEccLib

[gbarkhatov]

Currently we rely on initEccLib for Keystone to work. We might have conflicts depending on the consumer (like simple-staking).

          lol. looks wrong to me haha.

this initEccLib should be done inside the btc-staking-ts lib once only. should have nothing to do with wallets.

Could you raise an issue to track this? i think this is quite important. if we have two sets of ecc initiated and they have different versions. some unexpected random things could happen.
we should remove it from wallet repo and check how it goes. IMO nothing will happen

Originally posted by @jrwbabylonlab in #127 (comment)

[gbarkhatov]

@jrwbabylonlab thing we need to discuss is whether initEccLib from btc-staking-ts is needed
Should this particular library bbn-wallet-connect rely on btc-staking-ts?

[jrwbabylonlab]

this bbn-wallet-connect should not rely on btc-stakingts-ts
what's the use-case of initEcclib in this bbn-wallet-connect?

Note that IMO, we shall remove initEccLib everywhere in this repo under src (it's ok to have it as devDependency if we need it for tests)

[gbarkhatov]

@jrwbabylonlab I'll see what I can do and how I can extract initEccLib. Right now it is required for Keystone provider to work since it relies on bitcoinjs-lib heavily. So if you remove that line and link the npm library it won't work on simple-staking

[jrwbabylonlab]

Ah, gotcha. That makes sense to me in this case.

Yes, let’s investigate this when we pick up the ticket to see if it’s possible to remove it from here.