Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign all taproot transactions using walletprocesspsbt endpoint #17

Closed
KonradStaniec opened this issue Jul 31, 2024 · 1 comment
Closed

Sign all taproot transactions using walletprocesspsbt endpoint #17

KonradStaniec opened this issue Jul 31, 2024 · 1 comment
Assignees
@KonradStaniec
Labels
phase-2 critical

Comments

@KonradStaniec
Copy link
Collaborator

Currently signing of such transactions is done by dumping private key and then creating signature and witness through btcd libraries.

This should be improved to avoid:

  • keeping private key in memory
  • transfering private key from bitcoind wallet to staker program

The way to improve it is to use https://developer.bitcoin.org/reference/rpc/walletprocesspsbt.html, endpoint to sign such transactions
@KonradStaniec KonradStaniec self-assigned this Jul 31, 2024
@KonradStaniec
Copy link
Collaborator Author

closed by: #21

huynaism added a commit that referenced this issue Nov 8, 2024
@huynaism
hadolint #16,#17
b877e4f
filippos47 pushed a commit that referenced this issue Nov 22, 2024
@huynaism @filippos47
hadolint #16,#17
589698a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KonradStaniec KonradStaniec

Labels
phase-2 critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KonradStaniec