Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign taproot thorugh psbt #21

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Sign taproot thorugh psbt #21

merged 3 commits into from
Aug 12, 2024

Conversation

KonradStaniec
Copy link
Collaborator

@KonradStaniec KonradStaniec commented Aug 12, 2024 •
edited
Loading

ref: https://github.com/babylonlabs-io/pm/issues/20

  • Removes DumpPrivateKey from the staker codebase
  • Uses walletprocesspsbt to sign taproot spends
  • bump bitcoind to v26 in e2e test

RafilxTenfen
RafilxTenfen approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@KonradStaniec KonradStaniec merged commit 2645e95 into dev Aug 12, 2024
8 checks passed
@KonradStaniec KonradStaniec deleted the sign-taproot-thorugh-psbt branch August 12, 2024 14:30
@KonradStaniec KonradStaniec mentioned this pull request Aug 20, 2024
Closed
huynaism added a commit that referenced this pull request Nov 8, 2024
@huynaism
hadolint #21
0c9091c
filippos47 pushed a commit that referenced this pull request Nov 22, 2024
@huynaism @filippos47
hadolint #21
f1dc0d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@gitferry gitferry Awaiting requested review from gitferry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonradStaniec @RafilxTenfen