chore: Use int64 for satoshi amount configs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
force-pushed
the
vitsalis/satoshi-config-int64
branch
from
bf8da90 to
16687b8
Compare
vitsalis
changed the title
KonradStaniec
approved these changes
Oct 14, 2024
The libraries that we depend to use int64 for satoshi amount denominations. To be fully compatible with them, it is better if we use similar types instead of doing conversions. Further, this PR fixes some other type conversions and minor errors found by gosec.
vitsalis
force-pushed
the
vitsalis/satoshi-config-int64
branch
from
d31535c to
c1299c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libraries that we depend to use int64 for satoshi amount denominations. To be fully compatible with them,
it is better if we use similar types instead of doing conversions.
Further, this PR fixes some other type conversions and minor errors found by gosec.
Edit: tried to bump babylon dependency as well, but needs a version to be released first.