docs: transfer set up from a covenant signer to a covenant emulator #50
Conversation
|
Not sure about the structure of these guides. Maybe we should have the (./README.md)to hold the overviews of the programs as we do in finality provider |
docs/configure-emulator.md
Outdated
|
|
||
| After executing the above command, the key name will be saved in the config file | ||
| created in [step](#configuration). | ||
| Note that the `public-key` in the output should be used as one of the inputs of |
There was a problem hiding this comment.
I'm confused. Is this the public key that should be used for submitting transactions on Babylon or is this the key that the covenant signer is using?
The genesis file of Babylon should contain the covenant signer public key. The Babylon keyring does not relate to this afaik
There was a problem hiding this comment.
Yup, the covenant key which is maintained by covenant-emulator is only for signing and sending Babylon transactions.
It is not covenant key which should sign BTC transacitons. (this one is maintained by covenant-signer)
There was a problem hiding this comment.
Updated the name of the key to make it a little clearer
) * chore: bump babylon to v0.18.0 and update min unbonding time blocks to just unbonding time blocks, affected one check from '<' to '!=' * chore: add #57 to changelog * chore: bump bbn v018 in covenant-signer * fix: flag --min-unbonding-time * chore: move to UnbondingTimeBlocks higher than ComfirmationTimeBlocks
* feat: add babylon address to keys output and moved public-key to public-key-hex * fix: Casing on covenant-signer Dockerfile (#65) * chore: add #63 to changelog --------- Co-authored-by: Vitalis Salis <[email protected]>
…to sam/docs-import
There was a problem hiding this comment.
Structure of the docs is a bit weird:
- We have a README file that outlines the two major programs in the repository: covenant signer and emulator.
- For the covenant-signer, we have a README that points users to a transition guide from phase-1 to phase-2.
- Then for covenant-emulator, we only have docs mixing the transition (there's nothing to transition, it's a new program) and setting up of the program
Let's say I'm a covenant committee member. Which docs will be shared to me?
samricotta
force-pushed
the
sam/docs-import
branch
from
9e07181 to
4c1ed11
Compare
Summary
Currently we dont have documentation for transferring the setup from solely covenant signer to covenant emulator. This documentation serves that purpose.