-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add babylon address to keys output #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to rafilx/keys-add-babylon-addr
…-io/covenant-emulator into rafilx/keys-add-babylon-addr
vitsalis
approved these changes
Dec 9, 2024
samricotta
approved these changes
Dec 9, 2024
samricotta
pushed a commit
that referenced
this pull request
Dec 11, 2024
* feat: add babylon address to keys output and moved public-key to public-key-hex * fix: Casing on covenant-signer Dockerfile (#65) * chore: add #63 to changelog --------- Co-authored-by: Vitalis Salis <[email protected]>
samricotta
pushed a commit
that referenced
this pull request
Dec 17, 2024
* feat: add babylon address to keys output and moved public-key to public-key-hex * fix: Casing on covenant-signer Dockerfile (#65) * chore: add #63 to changelog --------- Co-authored-by: Vitalis Salis <[email protected]>
samricotta
added a commit
that referenced
this pull request
Dec 17, 2024
) * Create transfer-setup.md * Update transfer-setup.md * Update transfer-setup.md * Update transfer-setup.md * Update transfer-setup.md * Update transfer-setup.md * Update docs with new flow * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * updates * part 2 updates review * Update transition-guide.md * Update transition-guide.md * update toc * last updates for emulator and signer * add a bit * update docs for signer and emulator * Update transition-from-phase1.md * Update transition-from-phase1.md * review * comments * chore: add show key command that prints the pub key (#49) * chore: add show key command that prints the pub key * chore: address pr comments * chore: add #49 to changelog * feat: Add docker workflows for covenant_signer (#51) * Add cosmos tag for CosmosKeyStoreConfig (#52) * chore: bump workflows version (#56) * chore: bump babylon to v0.18.0 and update min unbonding time blocks (#57) * chore: bump babylon to v0.18.0 and update min unbonding time blocks to just unbonding time blocks, affected one check from '<' to '!=' * chore: add #57 to changelog * chore: bump bbn v018 in covenant-signer * fix: flag --min-unbonding-time * chore: move to UnbondingTimeBlocks higher than ComfirmationTimeBlocks * chore: add release to changelog (#58) (#59) (#64) * feat: add babylon address to keys output (#63) * feat: add babylon address to keys output and moved public-key to public-key-hex * fix: Casing on covenant-signer Dockerfile (#65) * chore: add #63 to changelog --------- Co-authored-by: Vitalis Salis <[email protected]> * Update covenant-emulator-setup.md * Update covenant-emulator-setup.md * Delete emulator-installation.md * comments * Update transition-from-phase1.md * restructuring * wip * small changes --------- Co-authored-by: Vitalis Salis <[email protected]> Co-authored-by: RafilxTenfen <[email protected]> Co-authored-by: maiquanghiep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public-key
topublic-key-hex
json formatcloses: #62