chore: adds unsafeSignEOTS for testing double signing #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Dec 5, 2024
eotsmanager/eotsmanager.go
Outdated
| @@ -31,6 +31,9 @@ type EOTSManager interface { | |||
| // or passPhrase is incorrect | |||
| SignEOTS(uid []byte, chainID []byte, msg []byte, height uint64, passphrase string) (*btcec.ModNScalar, error) | |||
|
|
|||
| // UnsafeSignEOTS should only be used in e2e tests for demonstration purposes. Use SignEOTS for real operations | |||
There was a problem hiding this comment.
We should mention that UnsafeSignEOTS does not check double-sign
| @@ -31,6 +31,9 @@ type EOTSManager interface { | |||
| // or passPhrase is incorrect | |||
| SignEOTS(uid []byte, chainID []byte, msg []byte, height uint64, passphrase string) (*btcec.ModNScalar, error) | |||
There was a problem hiding this comment.
We can mention that SignEOTS should have built-in anti-slashing mechanism to ensure signature for the same height will not be signed twice
gitferry
reviewed
Dec 5, 2024
itest/e2e_test.go
Outdated
| //require.NotNil(t, extractedKey) | ||
| //localKey := tm.GetFpPrivKey(t, fpIns.GetBtcPkBIP340().MustMarshal()) | ||
| //require.True(t, localKey.Key.Equals(&extractedKey.Key) || localKey.Key.Negate().Equals(&extractedKey.Key)) | ||
| _, extractedKey, err = fpIns.TestSubmitFinalitySignatureAndExtractPrivKey(b) |
There was a problem hiding this comment.
I was thinking that maybe we should keep an option to use SignEOTS within TestSubmitFinalitySignatureAndExtractPrivKey other than only the unsafe one so that we can test if the slashing protection works
gitferry
reviewed
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.