Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accomodate ADR-25 to add jailed status to fp instance #56

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat: accomodate ADR-25 to add jailed status to fp instance #56

merged 5 commits into from
Sep 19, 2024

Conversation

gitferry
Copy link
Member

Partially closes #5 by introducing jailed status to the fp instance. The jailing status can be found in two ways:

  1. The status update loop periodically checks whether the fp is slashed or jailed
  2. Upon ErrFpAlreadyJailed error when submitting finality signature

Once jailing is detected, the status of the fp instance will be set to jailed and terminated.

RafilxTenfen
RafilxTenfen approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gitferry gitferry mentioned this pull request Sep 18, 2024
Merged
4 tasks
Lazar955
Lazar955 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

gitferry added a commit to babylonlabs-io/babylon that referenced this pull request Sep 19, 2024
@gitferry
feat(ADR-025): Enable jailing and unjailing (#80)
e7ac8fd 
Closes #64.

TODOs:
- [x] #65 
- [x] #74
- [x] babylonlabs-io/finality-provider#56 
- [x] #81 

We still need to update the docs, add CLI cmd, and e2e tests but can be
done in separate PRs
SebastianElvis pushed a commit to babylonlabs-io/babylon that referenced this pull request Sep 19, 2024
@gitferry @SebastianElvis
feat(ADR-025): Enable jailing and unjailing (#80)
747ca8e 
Closes #64.

TODOs:
- [x] #65
- [x] #74
- [x] babylonlabs-io/finality-provider#56
- [x] #81

We still need to update the docs, add CLI cmd, and e2e tests but can be
done in separate PRs
@gitferry gitferry merged commit 8c63dae into main Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@Lazar955 Lazar955 Lazar955 approved these changes

@SebastianElvis SebastianElvis Awaiting requested review from SebastianElvis

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate jailing inactive finality providers
3 participants
@gitferry @Lazar955 @RafilxTenfen