chore: Remove running multiple fp instances support #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
force-pushed
the
gai/remove-multiple-fp-support
branch
from
8088f44 to
7619727
Compare
gitferry
force-pushed
the
gai/remove-multiple-fp-support
branch
from
7619727 to
72fb47f
Compare
gitferry
force-pushed
the
gai/remove-multiple-fp-support
branch
from
b5d4a20 to
b3fd5af
Compare
gitferry
requested review from
SebastianElvis,
RafilxTenfen,
Lazar955 and
KonradStaniec
and removed request for
RafilxTenfen
Lazar955
approved these changes
Oct 9, 2024
|
Merging this PR for now. Will address the remaining comments in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly addresses #34 by disallowing running multiple fp instances within the fp manager. Keyring level improvement will be done in a separate PR to address #63. Notable changes in this PR:
MaxNumFinalityProvidersfrom config as it is not applicable--eots-pkis not specified infpd start, fp app will start without any fp instances. To run a fp instance,--eots-pkmust be given