Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fee Component #72

Open
jeremy-babylonlabs opened this issue Aug 14, 2024 · 3 comments
Open

Improve Fee Component #72

jeremy-babylonlabs opened this issue Aug 14, 2024 · 3 comments
Assignees

Comments

@jeremy-babylonlabs
Copy link
Contributor

jeremy-babylonlabs commented Aug 14, 2024

The fee components are tightly coupled with at least 3 react components:

  • staking
  • stakingFee
  • stakingAmount

If you try adjust the fee rate, you will notice the react components of the stakingFee has been re-rendered at least 8 times.
The suggest the current state of implementation is not ideal for future feature work as it's prone to bugs.

The scope of this ticket is to investigate the best way moving forward to improve this part of the codebase and abstract the fee logic away from the core staking.tsx file.

@jeremy-babylonlabs jeremy-babylonlabs changed the title Add button to switch back to Suggested Settings after selecting custom Improve Fee Component: Add toggle for Suggested/Custom settings and display UTXO warnings Aug 14, 2024
@jeremy-babylonlabs jeremy-babylonlabs changed the title Improve Fee Component: Add toggle for Suggested/Custom settings and display UTXO warnings Improve Fee Component Aug 14, 2024
@jrwbabylonlab
Copy link
Collaborator

bumping this ticket to high priority as i think we should have it fixed before cap 3

fyi @gbarkhatov @totraev

@jrwbabylonlab
Copy link
Collaborator

During the week we have decided onhold the #72 and work on the smaller tickets that will eventually simplify the workflow for the #72. Otherwise the change might be too big and risky.
#173
#9
#162
#49

@jrwbabylonlab
Copy link
Collaborator

Hi @totraev what's the status of this ticket? has the implementation started? If not, we shall move the ticket back to todo state and one of the other devs can pick it up if have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants