Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(btcstaking-tracker): fix race condition #35

Merged
merged 6 commits into from
Sep 10, 2024
Merged

fix(btcstaking-tracker): fix race condition #35

merged 6 commits into from
Sep 10, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Sep 10, 2024 •
edited
Loading

  • Fixes race condition where *btcec.PrivateKey is accessed from multiple go routines where read/write happen in NewDecyptionKeyFromBTCSK from pkg github.com/babylonlabs-io/babylon/crypto/schnorr-adaptor-signature
  • Add -race flag to detect race conditions early
  • Fixes issue and references issue

RafilxTenfen
RafilxTenfen approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Lazar955 Lazar955 merged commit 8cb1b95 into main Sep 10, 2024
8 checks passed
@Lazar955 Lazar955 deleted the lazar/fix-race-cond branch September 10, 2024 18:39
@Lazar955 Lazar955 mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec

@gitferry gitferry Awaiting requested review from gitferry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix btcstacking-tracker race condition
2 participants
@Lazar955 @RafilxTenfen