chore(e2e): e2e test for activating and unbonded in mempool #71
Conversation
| // In this test, we include both staking tx and unbonding tx in the same block. | ||
| // The delegation goes through "VERIFIED" → "ACTIVE" → "UNBONDED" status throughout this test. | ||
| func TestActivatingAndUnbondingDelegation(t *testing.T) { | ||
| //t.Parallel() |
There was a problem hiding this comment.
for some reason, there might be an unwanted dependancy between e2e test, making it sequential until, will investigate (related to btc frequent headers maybe)
There was a problem hiding this comment.
"works on my machine" type of thing 😅
| // we should track both verified and active status for unbonding | ||
| if sew.unbondingTracker.GetDelegation(delegation.StakingTx.TxHash()) == nil { | ||
| changed, exists := sew.unbondingTracker.HasDelegationChanged(delegation.StakingTx.TxHash(), del) |
There was a problem hiding this comment.
the delegation might have changed from verified to active status, in order to track unbonding, we need the activation height, and data in the tracker might be stale, so let's check this
There was a problem hiding this comment.
this was a bit confusing the checks exists && changed or !exists
If the delegation didn't exists, we still push it as a new delegation to the unbondingDelegationChan?
There was a problem hiding this comment.
Yes, we want to track it, but we also want to push it to the channel if it exits and has changed (e.g went from verified -> activated)
|
|
||
| // Compare fields to check if the delegation has changed | ||
| if existingDelegation.StakingOutputIdx != newDelegation.stakingOutputIdx || | ||
| !reflect.DeepEqual(existingDelegation.UnbondingOutput, newDelegation.unbondingOutput) || |
There was a problem hiding this comment.
hmm I think the only thing that could have changes is .DelegationStartHeight ? I.e
.StakingOutputIdxwill always be the same.UnbondingOutputwill always be the same.DelegationStartHeightcan change from0to some other value when providing proof of inclusion
So maybe lets be explicit here at compare only DelegationStartHeight ?
This PR introduces an end-to-end test to validate that when both a staking transaction and an unbonding transaction are included in the same block, the delegation correctly transitions to the "UNBONDED" status.
This PR introduces an end-to-end test to validate that when both a staking transaction and an unbonding transaction are included in the same block, the delegation correctly transitions to the "UNBONDED" status.